Skip to content

Moved caching in AbstractHolidayCalendar to the instance level #9555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2015
Merged

Moved caching in AbstractHolidayCalendar to the instance level #9555

merged 1 commit into from
Apr 14, 2015

Conversation

dhirschfeld
Copy link
Contributor

Closes #9552

@dhirschfeld
Copy link
Contributor Author

image

@jreback jreback modified the milestone: Next Major Release Mar 3, 2015
@jreback jreback changed the title Moved caching in AbstractHolidayCalendar to the instance level Moved caching in AbstractHolidayCalendar to the instance level Apr 13, 2015
@jreback
Copy link
Contributor

jreback commented Apr 13, 2015

@dhirschfeld this looks good. Can you add a release note in Bug fixes, and squash. ping me when pushed.

@jreback jreback added Bug Datetime Datetime data dtype labels Apr 13, 2015
@jreback jreback modified the milestones: 0.16.1, Next Major Release Apr 13, 2015
@dhirschfeld dhirschfeld force-pushed the calendar-cache branch 3 times, most recently from cb3a845 to 9d023f1 Compare April 13, 2015 13:44
@dhirschfeld
Copy link
Contributor Author

@jreback - added a comment in whatsnew/v0.16.1.txt. Let me know if that's ok.

@jreback
Copy link
Contributor

jreback commented Apr 13, 2015

@dhirschfeld looks good. pls ping when green.

@dhirschfeld
Copy link
Contributor Author

@jreback - looks like travis finally got there in the end!

@dhirschfeld
Copy link
Contributor Author

@jreback - rebased after conflicts in whatsnew/v0.16.1.txt. Will ping when travis says ok

jreback added a commit that referenced this pull request Apr 14, 2015
@jreback
Merge pull request #9555 from dhirschfeld/calendar-cache
cef3c85 
Moved caching in AbstractHolidayCalendar to the instance level
@jreback jreback merged commit cef3c85 into pandas-dev:master Apr 14, 2015
@jreback
Copy link
Contributor

jreback commented Apr 14, 2015

thanks @dhirschfeld

@dhirschfeld dhirschfeld deleted the calendar-cache branch April 14, 2015 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Datetime Datetime data dtype
Projects
None yet
Milestone
0.16.1
Development

Successfully merging this pull request may close these issues.

Disable class level caching in AbstractHolidayCalendar
2 participants
@dhirschfeld @jreback